Register missing units to addUnit #282
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
============================================
+ Coverage 67.46% 67.71% +0.24%
Complexity 234 234
============================================
Files 42 42
Lines 1297 1307 +10
Branches 124 124
============================================
+ Hits 875 885 +10
Misses 388 388
Partials 34 34 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/main/java/edu/ie3/util/quantities/PowerSystemUnits.java
…into df/#280_addUnit_quantity_units
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
# Conflicts: # CHANGELOG.md # src/main/java/edu/ie3/util/quantities/PowerSystemUnits.java
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| // varh, kvarh, Mvarh are kept out of this because they register for the same units as Wh, kWh, | ||
| // MWh |
There was a problem hiding this comment.
I added this remark for a reason... Something broke, when I added varh etc., because they collided with Wh etc.
You should do thorough testing, also in SIMONA, with this...
There was a problem hiding this comment.
Just to document this and to avoid having to search for this again... The problem becomes apparent when debugging the new test.
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: edu.ie3:utils |
|
Does it make sense to keep on here with respect to squants? Whats your opinion @sebastian-peter |
|
@danielfeismann I think this can still be valuable, we're not close to being completely done with javax quantities |
resolves #280