Handle line sections #157
Merged
Handle line sections #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 86.46% 86.37% -0.10%
==========================================
Files 39 40 +1
Lines 872 932 +60
Branches 1 1
==========================================
+ Hits 754 805 +51
- Misses 118 127 +9
Continue to review full report at Codecov.
|
|
!test |
…ections # Conflicts: # src/test/resources/pfGrids/exampleGrid.json
sebastian-peter
requested changes
Dec 21, 2021
src/main/scala/edu/ie3/powerFactory2psdm/converter/types/LineTypeConverter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/converter/types/LineTypeConverter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/converter/types/LineTypeConverter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/converter/types/LineTypeConverter.scala
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/model/entity/LineSection.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/model/entity/LineSection.scala
Outdated
Show resolved
Hide resolved
|
Oh and btw, I think it would make sense to note these additions and changes in |
sebastian-peter
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #141