Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes in PvModel and test #689

Merged
merged 45 commits into from
Feb 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
dbfc369
initial implementation of new functions
SimonHuette Dec 20, 2023
55f24cd
Merge branch 'dev' into sh/#688-rewrite-pv-model
SimonHuette Dec 20, 2023
66cd6eb
noticed an error in Test
SimonHuette Dec 20, 2023
e7473d0
Merge remote-tracking branch 'origin/sh/#688-rewrite-pv-model' into s…
SimonHuette Dec 20, 2023
1c92a27
attempt to fix error with wrong unit in the variable timeFrame
SimonHuette Jan 7, 2024
684e9cd
added comment
SimonHuette Jan 17, 2024
eb59fd4
fixed epsilon + testing beam radiation
SimonHuette Jan 22, 2024
bb05389
testing beam and diffuse radiation
SimonHuette Jan 25, 2024
e7e9bcc
further testing
SimonHuette Jan 26, 2024
bd362d9
testing
SimonHuette Jan 29, 2024
8fbf117
noticed error in CalcExtraterrestrialRadiation
SimonHuette Jan 29, 2024
993b0fd
adjusted values for extraterrestrial radiation in test function
SimonHuette Jan 29, 2024
8e8549e
found error in GroovyTest (wrong data)
SimonHuette Feb 7, 2024
88d1062
Merge branch 'dev' into sh/#688-rewrite-pv-model
SimonHuette Mar 5, 2024
761e8eb
spotless apply
SimonHuette Mar 5, 2024
e725f06
added sources in documentation
SimonHuette Mar 30, 2024
b755427
angle in degrees documentation
SimonHuette Mar 30, 2024
ac0828e
updated links in library
SimonHuette Mar 30, 2024
69536ea
A tiny bit of cleanup
sebastian-peter Sep 16, 2024
b5c03d1
Reverting different sloped surface workaround
sebastian-peter Sep 16, 2024
4a54db3
Reverting changed eccentricity correction factor
sebastian-peter Sep 16, 2024
27e382a
Reverting changes in test
sebastian-peter Sep 16, 2024
e373f7f
Merge branch 'dev' into sh/#688-rewrite-pv-model
sebastian-peter Jan 26, 2025
1b78b88
Applying corrections to PvModelSpec
sebastian-peter Jan 27, 2025
0e850ab
Removing testing methods, fixing formatting
sebastian-peter Jan 27, 2025
6607121
Removing old test
sebastian-peter Jan 27, 2025
866170b
Replacing questionable source
sebastian-peter Jan 27, 2025
72645c7
Adding hint about Duffie 5th ed
sebastian-peter Jan 27, 2025
a7bd94f
renaming brightness parameter as delta
danielfeismann Jan 28, 2025
6a0bdf0
use Megajoule as input to increase comprehensibility of test
danielfeismann Jan 28, 2025
780f581
typo
danielfeismann Jan 28, 2025
08828f0
Apply suggestions from code review
sebastian-peter Jan 28, 2025
dc73481
Enhancing hint about typo in Duffie
sebastian-peter Jan 28, 2025
a067609
Fixing math mode subscripts
sebastian-peter Jan 28, 2025
bda5e36
Adding hints about normal incidence radiation and theta z in deg
sebastian-peter Jan 28, 2025
8599bdd
fmt
sebastian-peter Jan 28, 2025
2a738a5
Merge branch 'dev' into sh/#688-rewrite-pv-model
sebastian-peter Jan 28, 2025
1886b61
Merge branch 'dev' into sh/#688-rewrite-pv-model
danielfeismann Jan 28, 2025
770813c
Getting rid of var and Java code
sebastian-peter Jan 28, 2025
29484a2
Unused import
sebastian-peter Jan 28, 2025
c9a369b
Fixing the first of two EmAgentIT tests
sebastian-peter Jan 28, 2025
62f0673
Fixing the second of two EmAgentIT tests
sebastian-peter Jan 29, 2025
a695856
Merge branch 'dev' into sh/#688-rewrite-pv-model
danielfeismann Jan 31, 2025
71d770b
Adapting results of PvModelITSpec to new method
sebastian-peter Feb 3, 2025
bcb9008
Merge branch 'dev' into sh/#688-rewrite-pv-model
danielfeismann Feb 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing math mode subscripts
Signed-off-by: Sebastian Peter <sebastian.peter@tu-dortmund.de>
  • Loading branch information
sebastian-peter committed Jan 28, 2025
commit a0676094fc444a8661feed7100ba8b15d7309363
30 changes: 15 additions & 15 deletions docs/readthedocs/models/pv_model.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ $$
Calculating the air mass ratio by dividing the radius of the earth with approx. effective height of the atmosphere (each in kilometer)

$$
airmassratio = (\frac{6371 km}{9 km}) = 707.8\overline{8}
\mathrm{airmassratio} = (\frac{6371 km}{9 km}) = 707.8\overline{8}
$$

$$
airmass = \sqrt{(707.8\overline{8} \cdot \cos({\theta_z}))^2 +2 \cdot 707.8\overline{8} +1)} - 707.8\overline{8} \cdot \cos{(\theta_z)})
\mathrm{airmass} = \sqrt{(707.8\overline{8} \cdot \cos({\theta_z}))^2 +2 \cdot 707.8\overline{8} +1)} - 707.8\overline{8} \cdot \cos{(\theta_z)})
$$

**References:**
Expand Down Expand Up @@ -276,7 +276,7 @@ b = (\cos(\phi) \cdot \cos(\delta)) \cdot (\sin(\omega_{2}) - \sin(\omega_{1}))
$$

$$
E_{beam,S} = E_{beam,H} \cdot \frac{a}{b}
E_{\mathrm{beam},S} = E_{\mathrm{beam},H} \cdot \frac{a}{b}
$$

**Please note:** $\frac{1}{180}\pi$ is omitted from these formulas, as we are already working with data in *radians*.
Expand All @@ -288,7 +288,7 @@ $$
**$\omega_1$** = hour angle $\omega$\
**$\omega_2$** = hour angle $\omega$ + 1 hour\
**$\alpha_e$** = surface azimuth angle\
**$E_{beam,H}$** = beam radiation (horizontal surface)
**$E_{\mathrm{beam},H}$** = beam radiation (horizontal surface)

**Reference:**

Expand All @@ -302,15 +302,15 @@ The diffuse radiation is computed using the Perez model, which divides the radia
A cloud index is defined by

$$
\epsilon = \frac{\frac{E_{dif,H} + E_{beam,H}}{E_{dif,H}} + 5.535 \cdot 10^{-6} \cdot \theta_{z}^3}{1 + 5.535 \cdot 10^{-6} \cdot \theta_{z}^3}
\epsilon = \frac{\frac{E_{\mathrm{dif},H} + E_{\mathrm{beam},H}}{E_{\mathrm{dif},H}} + 5.535 \cdot 10^{-6} \cdot \theta_{z}^3}{1 + 5.535 \cdot 10^{-6} \cdot \theta_{z}^3}
$$

where the angle $theta_{z}$ is in **degrees**.

Calculating a brightness index

$$
\Delta = m \cdot \frac{E_{dif,H}}{I_{0}}
\Delta = m \cdot \frac{E_{\mathrm{dif},H}}{I_{0}}
$$

**Perez Fij coefficients (Myers 2017):**
Expand Down Expand Up @@ -388,7 +388,7 @@ $$
the diffuse radiation can be calculated:

$$
E_{dif,S} = E_{dif,H} \cdot (\frac{1}{2} \cdot (1 +
E_{\mathrm{dif},S} = E_{\mathrm{dif},H} \cdot (\frac{1}{2} \cdot (1 +
cos(\gamma_{e})) \cdot (1- F_{1}) + \frac{a}{b} \cdot F_{1} +
F_{2} \cdot \sin(\gamma_{e}))
$$
Expand All @@ -400,8 +400,8 @@ $$
**$\gamma_{e}$** = slope angle of the surface\
**$I_{0}$** = Extraterrestrial Radiation\
**$m$** = air mass\
**$E_{beam,H}$** = beam radiation (horizontal surface)\
**$E_{dif,H}$** = diffuse radiation (horizontal surface)
**$E_{\mathrm{beam},H}$** = beam radiation (horizontal surface)\
**$E_{\mathrm{dif},H}$** = diffuse radiation (horizontal surface)

**References:**

Expand All @@ -414,12 +414,12 @@ $$
### Reflected Radiation on Sloped Surface

$$
E_{ref,S} = E_{Ges,H} \cdot \frac{\rho}{2} \cdot (1-
E_{\mathrm{ref},S} = E_{\mathrm{Ges},H} \cdot \frac{\rho}{2} \cdot (1-
\cos(\gamma_{e}))
$$

*with*\
**$E_{Ges,H}$** = total horizontal radiation ($E_{beam,H} + E_{dif,H})$\
**$E_{\mathrm{Ges},H}$** = total horizontal radiation ($E_{\mathrm{beam},H} + E_{\mathrm{dif},H})$\
**$\gamma_e$** = slope angle of the surface\
**$\rho$** = albedo

Expand All @@ -433,13 +433,13 @@ $$
Received energy is calculated as the sum of all three types of irradiation.

$$
E_{total} = E_{beam,S} + E_{dif,S} + E_{ref,S}
E_{\mathrm{total}} = E_{\mathrm{beam},S} + E_{\mathrm{dif},S} + E_{\mathrm{ref},S}
$$

*with*\
**$E_{beam,S}$** = Beam radiation\
**$E_{dif,S}$** = Diffuse radiation\
**$E_{ref,S}$** = Reflected radiation
**$E_{\mathrm{beam},S}$** = Beam radiation\
**$E_{\mathrm{dif},S}$** = Diffuse radiation\
**$E_{\mathrm{ref},S}$** = Reflected radiation

A generator correction factor (depending on month surface slope $\gamma_{e}$) and a temperature correction factor (depending on month) multiplied on top.

Expand Down
Loading