Fix activation of Hp when not under control of an EM #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description what caused the error / wrong behaviourWhen the lower temperature limit of the heat house is reached, the heat pump starts to operate, but not immediately when the limit is reached. This is caused by the fact that the maybeThreshold is calculated correctly, but is not added to the additionalActivationTicks. |
…ontrol-of-an-EM # Conflicts: # CHANGELOG.md
sebastian-peter
previously approved these changes
Aug 29, 2024
src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Peter <[email protected]>
sebastian-peter
approved these changes
Aug 29, 2024
sebastian-peter
deleted the
df/#922-Fix-activation-of-Hp-when-not-under-control-of-an-EM
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #922