fix: given name in citation details page + search filtering URL (#385)

* fix: reflect changes to data source structure

* fix: mypy complaint

main/query.py

@@ -459,7 +459,7 @@ def build_citation_for_docid(
     ])
     if primary_docid:
         refs = query_suppressing_user_input_error(
-            lambda: search_refs_docids(typeCast(DocID, primary_docid))
+            lambda: search_refs_docids(primary_docid)
         ) or []
 
     composite_item, valid = compose_bibitem(

main/templates/relaton/contributor.html

@@ -26,7 +26,7 @@
       </a>
     {% endwith %}
   {% elif val.person.name %}
-    {% with link=val|substruct_search_link:'{"contributor": [%s]};as_list=yes;only=person.name.completename.content,person.name.surname.content,person.name.forename[*].content' %}
+    {% with link=val|substruct_search_link:'{"contributor": [%s]};as_list=yes;only=person.name.completename.content,person.name.surname.content,person.name.given.forename[*].content' %}
       <a class="link" href="{{ link }}" title="Individual’s name">
         {% include "relaton/person_name.html" with val=val.person.name %}
       </a>

main/templates/relaton/keyword.html

@@ -1,5 +1,5 @@
 {% load relaton %}
 {% with link=val|substruct_search_link:'{"keyword": [%s]}' %}
   <a class="link whitespace-nowrap" href="{{ link }}"
-    >{{ val }}</a>
+    >{{ val.content }}</a>
 {% endwith %}

main/templates/relaton/person_name.html

@@ -1,6 +1,6 @@
 {% load common %}
 
-{% with val.surname.content as surname and val.completename.content as fullname and val.forename as given_names and val.initial|as_list as initials %}
+{% with val.surname.content as surname and val.completename.content as fullname and val.given.forename as given_names and val.initial|as_list as initials %}
   {% if fullname %}
     {{ fullname }}
   {% else %}