Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace target URL for DOI items #365

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Conversation

stefanomunarini
Copy link
Collaborator

@stefanomunarini stefanomunarini commented Aug 2, 2023

Fixes #332

@stefanomunarini stefanomunarini marked this pull request as draft August 2, 2023 16:22
@kesara
Copy link
Member

kesara commented Aug 3, 2023

Strange, that on macOS I can't produce the same mypy errors.
It doesn't complain.

bibxml/xml2rfc_adapters.py Outdated Show resolved Hide resolved
@stefanomunarini
Copy link
Collaborator Author

Strange, that on macOS I can't produce the same mypy errors.
It doesn't complain.

I also cannot reproduce the errors in my local setup on MacOS, hence the many commits

@kesara
Copy link
Member

kesara commented Aug 3, 2023

Strange, that on macOS I can't produce the same mypy errors.
It doesn't complain.

I also cannot reproduce the errors in my local setup on MacOS, hence the many commits

Actually, I was able to get the same errors. Sorry, It was an error on my part not being able to produce errors.

bibxml/xml2rfc_adapters.py Outdated Show resolved Hide resolved
@stefanomunarini
Copy link
Collaborator Author

Strange, that on macOS I can't produce the same mypy errors.
It doesn't complain.

I also cannot reproduce the errors in my local setup on MacOS, hence the many commits

Actually, I was able to get the same errors. Sorry, It was an error on my part not being able to produce errors.

Can you hint on what you had to change in your local setup to reproduce the error(s)?

@kesara
Copy link
Member

kesara commented Aug 3, 2023

Can you hint on what you had to change in your local setup to reproduce the error(s)?

Silly mistake, I was leaving the . at the end out. So mypy wasn't checking anything.

@stefanomunarini
Copy link
Collaborator Author

stefanomunarini commented Aug 3, 2023

Can you hint on what you had to change in your local setup to reproduce the error(s)?

Silly mistake, I was leaving the . at the end out. So mypy wasn't checking anything.

Interesting. If I run mypy on my local machine, I get a totally different error:

Screenshot 2023-08-03 at 13 14 18

EDIT: It seems like if I run "mypy ." it uses the global mypy, instead of the one installed in the virtualenv. I'll need to investigate on this one

Screenshot 2023-08-03 at 13 17 00

Anyway, the PR is now ready to be merged @kesara

@stefanomunarini stefanomunarini marked this pull request as ready for review August 3, 2023 12:18
bibxml/xml2rfc_adapters.py Outdated Show resolved Hide resolved
@kesara kesara changed the title chore: replace target URL for DOI items fix: Replace target URL for DOI items Aug 3, 2023
@kesara kesara merged commit 64d4a33 into ietf-tools:main Aug 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bibxml-doi (bibxml7): target URL should use https and doi.org
2 participants