Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: given name in citation details page + search filtering URL #385

Merged
merged 2 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ def build_citation_for_docid(
])
if primary_docid:
refs = query_suppressing_user_input_error(
lambda: search_refs_docids(typeCast(DocID, primary_docid))
lambda: search_refs_docids(primary_docid)
) or []

composite_item, valid = compose_bibitem(
Expand Down
2 changes: 1 addition & 1 deletion main/templates/relaton/contributor.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</a>
{% endwith %}
{% elif val.person.name %}
{% with link=val|substruct_search_link:'{"contributor": [%s]};as_list=yes;only=person.name.completename.content,person.name.surname.content,person.name.forename[*].content' %}
{% with link=val|substruct_search_link:'{"contributor": [%s]};as_list=yes;only=person.name.completename.content,person.name.surname.content,person.name.given.forename[*].content' %}
<a class="link" href="{{ link }}" title="Individual’s name">
{% include "relaton/person_name.html" with val=val.person.name %}
</a>
Expand Down
2 changes: 1 addition & 1 deletion main/templates/relaton/person_name.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% load common %}

{% with val.surname.content as surname and val.completename.content as fullname and val.forename as given_names and val.initial|as_list as initials %}
{% with val.surname.content as surname and val.completename.content as fullname and val.given.forename as given_names and val.initial|as_list as initials %}
{% if fullname %}
{{ fullname }}
{% else %}
Expand Down