Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use correct environment variable for release version #431

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: Use correct environment variable for release version #431

merged 1 commit into from
Jul 5, 2024

Conversation

microamp
Copy link
Contributor

@microamp microamp commented Jul 5, 2024

Fixes #429

The environment variable being used in https://github.com/ietf-tools/bibxml-service/blob/main/docs/conf.py is SNAPSHOT, not VERSION.

release = f"v{os.environ.get('SNAPSHOT', 'N/A') or 'N/A'}"

Please double check if VERSION is currently being used elsewhere.

@microamp microamp requested a review from kesara July 5, 2024 03:11
@kesara
Copy link
Member

kesara commented Jul 5, 2024

I can't see VERSION being used.

@kesara kesara merged commit 9cc19a2 into ietf-tools:main Jul 5, 2024
2 checks passed
@microamp microamp deleted the fix/release-version-in-doc-heading branch July 5, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesara kesara kesara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid release version in documentation heading
2 participants
@microamp @kesara