Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assignment as dropdown (non drag) #165

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

holloway
Copy link
Contributor

@holloway holloway commented Aug 16, 2024

Allows assignments by dropdown rather than drag-n-drop (because the dragable areas were visibly too large to be easy to use)

It looks like this

Screenshot from 2024-08-21 09-09-18

NOTE WELL : The above data looks like real drafts and real people, but the dates and assignments are test data, not real data. This doesn't reflect what's actually happening in the RPC right now at all.

@ajeanmahoney
Copy link
Collaborator

Is the order alphabetical by first name? If someone could complete the assignment earlier, would they be listed first?

@rjsparks
Copy link
Member

We can make the order by "best match". For now, that could be "earliest date".

@holloway
Copy link
Contributor Author

I'll change the ordering.

What do you think of the UX in general? Is it usable? Any feedback?

If it's ok then I'll tidy up this PR and ask for a code review.

@ajeanmahoney
Copy link
Collaborator

Inactive editors (i.e., Jon Postel, Joyce Reynolds) should not be listed in the drop-down menu. If the editor already is working on an assignment, the description should say that (e.g., "Currently assigned draft-foo-06, 86 pages"), thanks!

@rjsparks
Copy link
Member

removing inactive editors will come in with different work.

@holloway - tidy this up as suggested. I'll make another issue for adding information about current assignments to the dropdowns.

@holloway
Copy link
Contributor Author

@rjsparks done and screenshot updated on this PR.

fixes #168

@holloway holloway marked this pull request as ready for review August 20, 2024 21:36
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Hope you don't mind, but I removed a few prototype components that were left unused by your refactoring.

@jennifer-richards jennifer-richards merged commit ea0c1be into ietf-tools:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants