-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: assignment as dropdown (non drag) #165
feat: assignment as dropdown (non drag) #165
Conversation
Is the order alphabetical by first name? If someone could complete the assignment earlier, would they be listed first? |
We can make the order by "best match". For now, that could be "earliest date". |
I'll change the ordering. What do you think of the UX in general? Is it usable? Any feedback? If it's ok then I'll tidy up this PR and ask for a code review. |
Inactive editors (i.e., Jon Postel, Joyce Reynolds) should not be listed in the drop-down menu. If the editor already is working on an assignment, the description should say that (e.g., "Currently assigned draft-foo-06, 86 pages"), thanks! |
removing inactive editors will come in with different work. @holloway - tidy this up as suggested. I'll make another issue for adding information about current assignments to the dropdowns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Hope you don't mind, but I removed a few prototype components that were left unused by your refactoring.
Allows assignments by dropdown rather than drag-n-drop (because the dragable areas were visibly too large to be easy to use)
It looks like this
NOTE WELL : The above data looks like real drafts and real people, but the dates and assignments are test data, not real data. This doesn't reflect what's actually happening in the RPC right now at all.