Provide a ROS like way to change temporary parameters on the fly #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpanzarella
reviewed
Mar 2, 2019
src/camera_nodelet.cpp
Outdated
| } | ||
| catch (const ifm3d::error_t& ex) | ||
| { | ||
| NODELET_WARN_STREAM("Could not set exposure times, " << ex.code() << ": " << ex.what()); |
There was a problem hiding this comment.
Looks like you have a copy/paste error here in your log message.
Implements set\get of temporary application parameters using a topic based approach
cveezee
force-pushed
the
temporary-parameters
branch
from
1d6fc3a to
b7d15b3
Compare
|
Hi @cveezee thanks for taking the time to submit a PR, and I apologize for the time it's taken us to give it proper attention. I've added this to our backlog and will schedule it in for a milestone in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements set\get of temporary application parameters using a topic based approach
more info about this feature can be found in doc/changing_temporary_parameters.md