Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve missing config file #28

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Resolve missing config file #28

wants to merge 8 commits into from

Conversation

FaresKchaou
Copy link
Member

@FaresKchaou FaresKchaou commented Feb 14, 2025

summary

Following #25 and PR #27, this PR is created and is based on #27.

In #27, the config file was added as a parameter, which is no longer optional. However, the intended idea was to make this parameter optional so that users configuring with the ifmVision Assistant or pure API are not required to reconfigure. They can simply publish the point clouds and ODS data without additional steps.

Additional Changes (form #27):

  • add missing declare_parameter for the config_file parameter in ods_node.cpp
  • Change RCLCPP_INFO to RCLCPP_DEBUG for logging the configuration contents in camera_node.cpp and ods_node.cpp because this produces a lot of output.

@FaresKchaou FaresKchaou changed the title Config file Resolve missing config file Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants