Fix for backwards compatibility, new feature ROIs and RODs for AutoFocus and new timeout mechanic for all clients #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation import if already existing on sensor
This was
linked to
issues
Mar 26, 2024
bnozka
requested changes
Mar 26, 2024
added 5 commits
March 27, 2024 09:32
…reTime and fixed usage in test_imager.py
…socket instance and not globally. Also added new unittest test_timeout_with_invalid_ip in test_rpc.py
…ince newly implemented timeout mechanic for PCIC
added 4 commits
March 27, 2024 10:11
…e newly implemented timeout mechanic for RPC
bnozka
reviewed
Mar 27, 2024
cfreundl
reviewed
Apr 3, 2024
source/device/client.py
Outdated
| self._autoconnect = autoconnect | ||
| self._pcic = None | ||
| self._rpc = None | ||
| if autoconnect: |
There was a problem hiding this comment.
Here I would also favor the removal of the if statement. The RPC client does not connect by itself anyway, and the PCIC client handles the autoconnect itself (the flag is passed to it). Having both clients instantiated unconditionally this simplifies the later access, i.e. the added checks in lines 58-59 and 64-66 can be removed again.
…removed unnecessary autoconnect methods and added tests for timeout mechanic for PCIC and RPC client
cfreundl
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.