Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More translations for ja.yml #1265

Merged
merged 4 commits into from
Nov 15, 2018
Merged

More translations for ja.yml #1265

merged 4 commits into from
Nov 15, 2018

Conversation

toryalsip
Copy link
Contributor

Description

This round includes reports and notifications.

Corresponding Issue

#1215

Test Coverage

reports and notifications

Co-authored-by: kapipan <[email protected]>
@toryalsip toryalsip self-assigned this Nov 14, 2018
@toryalsip toryalsip requested a review from nshki November 14, 2018 00:56
Copy link
Member

@nshki nshki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I left a bunch of little comments, so it seems like a ton, but they're all really kind of the same edit.

config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
config/locales/ja.yml Outdated Show resolved Hide resolved
@toryalsip
Copy link
Contributor Author

@nshki Thank you for the suggestions! A lot of good feedback. I'm so glad GitHub improved the suggested changes feature, very helpful! 👍

@nshki
Copy link
Member

nshki commented Nov 15, 2018

@nshki Thank you for the suggestions! A lot of good feedback. I'm so glad GitHub improved the suggested changes feature, very helpful! 👍

Yes! Super happy about this feature too.

@toryalsip toryalsip merged commit d92a41e into ifmeorg:ja-translations Nov 15, 2018
@toryalsip toryalsip deleted the ja-yml-reports-and-notifications branch November 15, 2018 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants