Remove reminder's deletion from MedicationsController #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
enhancement/remove-dependent-from-controller
branch
from
7477373 to
062056b
Compare
brunoocasali
commented
Dec 14, 2021
| .to(change(Medication, :count).by(-1)) | ||
| expect(TakeMedicationReminder.active.count).to eq(0) | ||
| expect { | ||
| delete medication_path(medication) |
There was a problem hiding this comment.
Improve the readability of these tests, and fix some assertions after that.
brunoocasali
commented
Dec 14, 2021
| let!(:medication) do | ||
| create(:medication, :with_daily_reminder, user: user) | ||
| end | ||
| let!(:medication) { create(:medication, user: user) } |
There was a problem hiding this comment.
There is an after creating a hook into the factories that creates a take_medication_reminder and a refill_reminder, as we have a has_one relation during the tests we have been creating two objects (2 take_medication_reminder and 2 refill_reminder) for the same medication, in other words, we are creating an inconsistency in the tests. So I fixed that here.
julianguyen
approved these changes
Dec 15, 2021
delete-merged-branch
bot
deleted the
enhancement/remove-dependent-from-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just improves code readability of reminders.
Part of issue 1601.
Related to: #1601