fixed issue in Modal component with nested interactive element #2333
+153
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack. |
julianguyen
force-pushed
the
2123-fix-issue-with-nested-interactive-elements-in-the-modal-component
branch
4 times, most recently
from
4a8788a
to
b834c5b
Compare
… is not interactive
julianguyen
force-pushed
the
2123-fix-issue-with-nested-interactive-elements-in-the-modal-component
branch
from
b834c5b
to
fb9276f
Compare
julianguyen
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue in Modal component. In the Modal component, the opener element is incorrectly given a role="button," which can cause problem with accessibility if the nested element is already interactive like a button or link. To fix this, I removed the "button" role when the nested element itself is interactive and has its own role. However, we should keep the "button" role on the opener if the nested interactive element lacks a specific role. This approach ensures proper accessibility handling without redundancy.
Corresponding Issue
#2123