Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle post videos & some refactor #329

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nightspite
Copy link

@nightspite nightspite commented Nov 5, 2022

I believe, that since the 7th of November 2022, Instagram also uses blobs for stories, so that needs an update

@HuiiBuh
Copy link
Collaborator

HuiiBuh commented Nov 11, 2022

Hey thanks for the PR.
I unfortunately do not have time to test your changes. Did you test it, so I can rollout a new release?

@nightspite
Copy link
Author

Downloading videos from posts works fine, but stories need an update. I could take care of that at the end of next week and then you could create a new release.

@HuiiBuh
Copy link
Collaborator

HuiiBuh commented Nov 13, 2022

That sounds awesome!
Thanks a lot

@aeadedoyin
Copy link

Hi, @nightspite thanks for helping out with this 🙏.
Have you been able to get to it? (since you said next week) just checking in.

@nightspite
Copy link
Author

@aeadedoyin Hey, I wasn't able to pick that up, unfortunately for lack of time. But the basic idea would be to find the required variables for the graphql posts and highlights query and the rest of the logic should be the same as for the posts.

@aeadedoyin
Copy link

@nightspite I figured.
I can push an update to this but that would mean,

  • forking your nightspite:master,
  • creating a new PR for you, which should reflect here, when merged.

Should I go ahead?

@nightspite
Copy link
Author

@aeadedoyin Yea, sure go ahead! That would be great.

@RichardReindeer
Copy link

@aeadedoyin Yea, sure go ahead! That would be great.

Sorry to bother . When I try to use this in my chrome , it tell me that "Manifest version 2 is deprecated, and support will be removed in 2023";
what I should do to fix this

@HuiiBuh
Copy link
Collaborator

HuiiBuh commented Dec 1, 2022

Just ignore it for now, it's only a warning, or at least I think it is.
I'll have to move to manifest v3 over the holidays

@aeadedoyin Yea, sure go ahead! That would be great.

Sorry to bother . When I try to use this in my chrome , it tell me that "Manifest version 2 is deprecated, and support will be removed in 2023"; what I should do to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants