fix: relayer spinner #163
Draft
fix: relayer spinner #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
commented
Feb 7, 2025
Comment on lines
+26
to
+44
| func stdOutRedirect() error { | ||
| // Save the current stdOut. | ||
| out := os.Stdout | ||
|
|
||
| // Create a new pseudo-terminal. | ||
| pty, tty, err := pty.Open() | ||
| if err != nil { | ||
| return errors.Errorf("Failed to create pty/tty: %v", err) | ||
| } | ||
|
|
||
| // Redirect os.Stdout and os.Stderr to the TTY. | ||
| os.Stdout = tty | ||
|
|
||
| // Start a goroutine to forward the output from the PTY to the real terminal. | ||
| go func() { | ||
| _, _ = io.Copy(out, pty) // Copy all output from the PTY to the real terminal. | ||
| }() | ||
| return nil | ||
| } |
There was a problem hiding this comment.
here is the workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLIUI uses the github.com/briandowns/spinner library, which checks if the output is a terminal since it can only be displayed in a terminal. The Ignite app adds a stdout layer, causing a misunderstanding about whether the output is a terminal.
This is a workaround for the library to prevent the spinner from being printed in the plugin. A better solution would involve changing the spinner logic or improving the detection mechanism.
Reference: https://github.com/briandowns/spinner/blob/master/spinner.go#L502-L506