refactor(cosmover): delete notion of app version (#3903)

* refactor(cosmover): delete notion of app version

* add changelog

changelog.md

@@ -8,7 +8,8 @@
 
 ### Changes
 
-- [#3899](https://github.com/ignite/cli/pull/3899) Introduce plugin.Execute function
+- [#3899](https://github.com/ignite/cli/pull/3899) Introduce `plugin.Execute` function
+- [#3903](https://github.com/ignite/cli/pull/3903) Don't specify a default build tag and deprecate notion of app version
 
 ### Bug Fixes
 

ignite/cmd/chain_build.go

@@ -9,7 +9,6 @@ import (
 	"github.com/ignite/cli/v28/ignite/pkg/chaincmd"
 	"github.com/ignite/cli/v28/ignite/pkg/cliui"
 	"github.com/ignite/cli/v28/ignite/pkg/cliui/colors"
-	"github.com/ignite/cli/v28/ignite/pkg/cosmosver"
 	"github.com/ignite/cli/v28/ignite/services/chain"
 )
 
@@ -91,7 +90,7 @@ for your current environment.
 	c.Flags().AddFlagSet(flagSetDebug())
 	c.Flags().Bool(flagRelease, false, "build for a release")
 	c.Flags().StringSliceP(flagReleaseTargets, "t", []string{}, "release targets. Available only with --release flag")
-	c.Flags().StringSlice(flagBuildTags, []string{cosmosver.DefaultVersion().String()}, "parameters to build the chain binary")
+	c.Flags().StringSlice(flagBuildTags, []string{}, "parameters to build the chain binary")
 	c.Flags().String(flagReleasePrefix, "", "tarball prefix for each release target. Available only with --release flag")
 	c.Flags().StringP(flagOutput, "o", "", "binary output path")
 	c.Flags().BoolP("verbose", "v", false, "verbose output")

ignite/cmd/chain_init.go

@@ -6,7 +6,6 @@ import (
 	"github.com/ignite/cli/v28/ignite/pkg/chaincmd"
 	"github.com/ignite/cli/v28/ignite/pkg/cliui"
 	"github.com/ignite/cli/v28/ignite/pkg/cliui/colors"
-	"github.com/ignite/cli/v28/ignite/pkg/cosmosver"
 	"github.com/ignite/cli/v28/ignite/services/chain"
 )
 
@@ -89,7 +88,7 @@ commands manually to ensure a production-level node initialization.
 	c.Flags().AddFlagSet(flagSetCheckDependencies())
 	c.Flags().AddFlagSet(flagSetSkipProto())
 	c.Flags().AddFlagSet(flagSetDebug())
-	c.Flags().StringSlice(flagBuildTags, []string{cosmosver.DefaultVersion().String()}, "parameters to build the chain binary")
+	c.Flags().StringSlice(flagBuildTags, []string{}, "parameters to build the chain binary")
 
 	return c
 }

ignite/cmd/chain_serve.go

@@ -10,7 +10,6 @@ import (
 	"github.com/ignite/cli/v28/ignite/pkg/cliui"
 	uilog "github.com/ignite/cli/v28/ignite/pkg/cliui/log"
 	cliuimodel "github.com/ignite/cli/v28/ignite/pkg/cliui/model"
-	"github.com/ignite/cli/v28/ignite/pkg/cosmosver"
 	"github.com/ignite/cli/v28/ignite/pkg/errors"
 	"github.com/ignite/cli/v28/ignite/pkg/events"
 	"github.com/ignite/cli/v28/ignite/services/chain"
@@ -76,7 +75,7 @@ production, you may want to run "appd start" manually.
 	c.Flags().BoolP(flagResetOnce, "r", false, "reset the app state once on init")
 	c.Flags().Bool(flagGenerateClients, false, "generate code for the configured clients on reset or source code change")
 	c.Flags().Bool(flagQuitOnFail, false, "quit program if the app fails to start")
-	c.Flags().StringSlice(flagBuildTags, []string{cosmosver.DefaultVersion().String()}, "parameters to build the chain binary")
+	c.Flags().StringSlice(flagBuildTags, []string{}, "parameters to build the chain binary")
 
 	return c
 }

ignite/pkg/cosmosanalysis/app/app_test.go

@@ -21,8 +21,8 @@ var (
 	NoAppFile []byte
 	//go:embed testdata/two_app.go
 	TwoAppFile []byte
-	//go:embed testdata/app_v2.go
-	AppV2 []byte
+	//go:embed testdata/app_di.go
+	AppDepinject []byte
 )
 
 func TestCheckKeeper(t *testing.T) {
@@ -55,8 +55,8 @@ func TestCheckKeeper(t *testing.T) {
 			expectedError: "app.go should contain a single app (got 2)",
 		},
 		{
-			name:       "app v2",
-			appFile:    AppV2,
+			name:       "app depinject",
+			appFile:    AppDepinject,
 			keeperName: "FooKeeper",
 		},
 	}

ignite/pkg/cosmosanalysis/app/testdata/app_v2.go → ignite/pkg/cosmosanalysis/app/testdata/app_di.go

@@ -1,4 +1,4 @@
-//go:build !app_v1
+//go:build !hack-to-no-include-deps-in-ignite
 
 package simapp