feat: add faucet compatibility for latest sdk chains #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt and
Ehsan-saradar
as code owners
ilgooz
previously approved these changes
Nov 15, 2023
Pantani
force-pushed
the
feat/legacy-faucet
branch
from
c5bc671 to
90e69fe
Compare
ilgooz
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the faucet work with the new SDK chains and the old SDK chain
Query events are different after the sdk version
v0.50. We should use thequeryflag, not theeventsflag, and the syntax changes slightly. The faucet tries to get the funds before sending, and the query is falling.