-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scaffold configs
and scaffold params
commands and start remove placeholders
#3770
Conversation
scaffold param
commandscaffold params
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the current and the fact this command is additive, doing a ignite s module bar
will still scaffold params. How are you supposed to use this command?
We can create a chain with a default module and add the parameters later: ignite s chain github.com/Pantani/mars && cd mars
ignite scaffold params foo bar:uint baz:bool -y Or we can also create a module with params and add more parameters later: ignite s chain github.com/Pantani/mars && cd mars
ignite scaffold module foo --params foo:uint,bar:bool -y
ignite scaffold params baz boo:uint bla:bool --module foo -y Let's create something in the docs about it. wdyt @toschdev ? |
# Conflicts: # ignite/cmd/scaffold_chain.go
scaffold configs
and scaffold params
commandsscaffold configs
and scaffold params
commands and start remove placeholders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
xast additions are amazing!
* feat: backport xast package to v28 Co-authored-by: Danilo Pantani <[email protected]>
… remove placeholders (#3770) * add parameters placeholders and modifier * add scaffold params command * add changelog * check if the parameter already exist * add integration tests and fix some import issues * improve the scaffolder logic * improve the log message * fix the log message * fix changelog * fix 28 imports * remove params module * add module configs command * rollbak empty line for proto * improve code readbility and add unit tests * fix changelog * use cli error package * Update ignite/cmd/scaffold_configs.go Co-authored-by: Jerónimo Albi <[email protected]> * apply pr suggestions * fix some typos * remove unused vars and casting * add replacer pkg for goanalysis * add TODO comment * add modify call function * test readbility * improve organization * fix the function modifier logic * fix the arg idente for caller replace * add more test cases and last fixes * start replace the params template to the xast * add append struct param option * add support to add new struct params * fix some lint issues * add small fixes and improve code readbility * fix append code parser * fix changelog --------- Co-authored-by: Pantani <Pantani> Co-authored-by: Jerónimo Albi <[email protected]>
close #3684
Description
Configs
We can create a chain with a default module and add the configs later:
Or we can also create a module with params and add more configs later:
Params
We can create a chain with a default module and add the parameters later:
Or we can also create a module with params and add more parameters later:
This PR also introduces a new way to add code without placeholders!!!