Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Shorten the DeFi loan tutorial #3771

Merged
merged 25 commits into from
Dec 20, 2023
Merged

docs: Shorten the DeFi loan tutorial #3771

merged 25 commits into from
Dec 20, 2023

Conversation

toschdev
Copy link
Contributor

As in the effort trying to shorten tutorials and make them leaner, I've addressed the DeFi Loan tutorial.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Visit the preview URL for this PR (updated for commit 1a16e18):

https://igntservices-docs--pr3771-docs-defi-loan-ax17ljul.web.app

(expires Wed, 27 Dec 2023 22:44:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@toschdev toschdev added the skip-changelog Don't check changelog for new entries label Nov 23, 2023
@toschdev
Copy link
Contributor Author

I've seen an interesting behaviour of

✘ panic: can't resolve type loan/x/loan/types/types.BankKeeper for loan/x/loan/module.ProvideModule (~/ignite/loan/x/loan/module/module.go:208)

When not removing the SpendableCoins from the BankKeeper in this tutorial.

@toschdev toschdev marked this pull request as ready for review November 24, 2023 09:11
Copy link
Member

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @toschdev. Sharing some suggestions.

docs/docs/02-guide/05-loan.md Outdated Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Outdated Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Outdated Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Outdated Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Outdated Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Show resolved Hide resolved
docs/docs/02-guide/05-loan.md Show resolved Hide resolved
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:configs labels Dec 2, 2023
@salmad3 salmad3 enabled auto-merge (squash) December 13, 2023 14:42
@salmad3 salmad3 merged commit 455f6e3 into main Dec 20, 2023
44 checks passed
@salmad3 salmad3 deleted the docs/defi-loan branch December 20, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:docs Documentation additions or improvements. skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants