Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: package ignite for flatpak and snap #3786

Merged
merged 18 commits into from
Dec 20, 2023
Merged

build: package ignite for flatpak and snap #3786

merged 18 commits into from
Dec 20, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 28, 2023 •
edited
Loading

Adds packaging support for Ignite (flatpak & snap)

@julienrbrt julienrbrt changed the title build: package ignite build: package ignite for flatpak and snap Nov 28, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Dec 2, 2023
@julienrbrt julienrbrt marked this pull request as ready for review December 4, 2023 10:59
@ilgooz ilgooz requested a review from mazzy89 December 5, 2023 13:33
mazzy89
mazzy89 previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@mazzy89 mazzy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snap release looks fine for me. good call from Danilo to bump automatically the version. Not sure if it is intended to be added in this PR.

Pantani
Pantani previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

It would be great if we create an issue so we can automate the releases in the package manager later in another PR

@julienrbrt
Copy link
Member Author

We should do that in a follow up and tweak the GitHub action yes.

@julienrbrt julienrbrt enabled auto-merge (squash) December 6, 2023 12:39
@julienrbrt julienrbrt mentioned this pull request Dec 6, 2023
Closed
4 tasks
Ehsan-saradar
Ehsan-saradar previously requested changes Dec 6, 2023
View reviewed changes
packaging/README.md Outdated Show resolved Hide resolved
@julienrbrt julienrbrt dismissed stale reviews from Pantani and mazzy89 via 097a7e9 December 6, 2023 15:08
@julienrbrt julienrbrt dismissed Ehsan-saradar’s stale review December 15, 2023 08:55

changes implemented

@julienrbrt julienrbrt merged commit 5569bf2 into main Dec 20, 2023
42 checks passed
@julienrbrt julienrbrt deleted the julien/flatpak branch December 20, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazzy89 mazzy89 mazzy89 left review comments

@toschdev toschdev toschdev approved these changes

@Pantani Pantani Pantani approved these changes

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@julienrbrt @jeronimoalbi @Pantani @mazzy89 @Ehsan-saradar @toschdev @salmad3