Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip analytics for the integration tests #3794

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Dec 1, 2023

Description

Skip analytics for the integration tests, setting the env var DO_NOT_TRACK to true, avoiding saving fake data, and fixing the integration tests. The test is stuck on the analytics question.

@Pantani Pantani self-assigned this Dec 1, 2023
@Pantani Pantani added the skip-changelog Don't check changelog for new entries label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #3794 (c5b93a9) into main (4001371) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3794   +/-   ##
=======================================
  Coverage   24.00%   24.01%           
=======================================
  Files         291      291           
  Lines       24212    24212           
=======================================
+ Hits         5813     5815    +2     
+ Misses      17882    17881    -1     
+ Partials      517      516    -1     

see 1 file with indirect coverage changes

@Pantani Pantani enabled auto-merge (squash) December 1, 2023 19:48
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@Pantani Pantani merged commit b62a3e7 into main Dec 1, 2023
27 of 28 checks passed
@Pantani Pantani deleted the fix/integration-test-analytics branch December 1, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants