Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use fmt.Sprintf instead add strings #3801

Merged
merged 3 commits into from
Dec 4, 2023
Merged

chore: use fmt.Sprintf instead add strings #3801

merged 3 commits into from
Dec 4, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Dec 4, 2023

Description

apply goconst lint rule

@Pantani Pantani self-assigned this Dec 4, 2023
julienrbrt
julienrbrt previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt added the skip-changelog Don't check changelog for new entries label Dec 4, 2023
@julienrbrt julienrbrt dismissed their stale review December 4, 2023 15:47

tests failing

@Pantani Pantani requested a review from julienrbrt December 4, 2023 17:17
@julienrbrt julienrbrt merged commit d6595bd into main Dec 4, 2023
43 checks passed
@julienrbrt julienrbrt deleted the chore/lint-goconst branch December 4, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages component:templates skip-changelog Don't check changelog for new entries type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt