Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set the proto-dir flag only for the scaffold chain command and use the proto path from the config #4100

Merged
merged 12 commits into from
Apr 25, 2024
Merged

feat: set the proto-dir flag only for the scaffold chain command and use the proto path from the config #4100

merged 12 commits into from
Apr 25, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Apr 23, 2024 •
edited
Loading

Description

  • Only use the proto-dir flag for scaffold chain command;
  • Only use the proto path from the config since the generate commands are always running and getting from the config file;

@Pantani Pantani self-assigned this Apr 23, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd labels Apr 23, 2024
@Pantani Pantani marked this pull request as draft April 23, 2024 14:51
@Pantani Pantani changed the title feat: only use the proto dir from config feat: set the proto-dir flag only for the scaffold chain command and use the proto path from the config Apr 24, 2024
@Pantani Pantani marked this pull request as ready for review April 24, 2024 00:43
julienrbrt
julienrbrt reviewed Apr 24, 2024
View reviewed changes
integration/app/cmd_proto_path_test.go Outdated Show resolved Hide resolved
ignite/cmd/cmd.go Show resolved Hide resolved
@Pantani Pantani requested a review from julienrbrt April 24, 2024 23:13
@julienrbrt julienrbrt merged commit af41d3d into main Apr 25, 2024
46 checks passed
@julienrbrt julienrbrt deleted the feat/proto-dir-from-config branch April 25, 2024 08:59
julienrbrt pushed a commit that referenced this pull request May 29, 2024
@Pantani @julienrbrt
feat: set the proto-dir flag only for the scaffold chain command …
92a0a05 
…and use the proto path from the config (#4100)

* only use the proto dir from config

* add proto dir only for scaffold a new chain

* add changelog

* fix integartion tests

* remove unused flag from integration tests cmds

* fix revive lint use

* add a helper to find the root chain path

* remove unused method

* remove unused tests

---------

Co-authored-by: Pantani <Pantani>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs type:internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt