Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean-up unecessary deps (backport #4121) #4122

Merged
merged 1 commit into from
May 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2024

Follow-up of #4097.
No need to bring in those dependencies in Ignite just for constants.
It is very unlikely that module names will change, so let's hardcode it instead.

Needs to be merged after this backport is merged: #4097


This is an automatic backport of pull request #4121 done by Mergify.

@mergify mergify bot requested a review from ilgooz as a code owner May 8, 2024 01:43
@mergify mergify bot added the conflicts label May 8, 2024
Copy link
Contributor Author

mergify bot commented May 8, 2024

Cherry-pick of 5f2ffb2 has failed:

On branch mergify/bp/release/v28.x.y/pr-4121
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 5f2ffb22.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ignite/pkg/cosmosclient/consensus.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod
	both modified:   go.sum
	both modified:   ignite/services/scaffolder/module.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. component:packages labels May 8, 2024
* chore: clean-up unecessary deps

* remove direct ibc deps
@julienrbrt julienrbrt force-pushed the mergify/bp/release/v28.x.y/pr-4121 branch from 71f0dd6 to 1ea73c9 Compare May 8, 2024 09:23
@julienrbrt julienrbrt added the skip-changelog Don't check changelog for new entries label May 8, 2024
@julienrbrt julienrbrt enabled auto-merge (squash) May 8, 2024 10:20
@julienrbrt julienrbrt merged commit 8d7d924 into release/v28.x.y May 8, 2024
44 of 46 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4121 branch May 8, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages skip-changelog Don't check changelog for new entries type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants