Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): correct relative path support #4125

Merged
merged 3 commits into from
May 13, 2024

Conversation

julienrbrt
Copy link
Member

Follow-up of #4117
Fixes some edge cases

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label May 9, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. type:internal labels May 9, 2024
@julienrbrt julienrbrt enabled auto-merge (squash) May 9, 2024 10:16
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

ignite/services/plugin/plugin.go Show resolved Hide resolved
@julienrbrt julienrbrt merged commit 75bf998 into main May 13, 2024
45 of 46 checks passed
@julienrbrt julienrbrt deleted the julien/follow-up-relative-path branch May 13, 2024 08:43
@julienrbrt
Copy link
Member Author

Clicking resolve on vscode while having auto-merge on isn't so great 😓

mergify bot pushed a commit that referenced this pull request May 13, 2024
* fix(plugins): correct relative path support

* updates

(cherry picked from commit 75bf998)
julienrbrt added a commit that referenced this pull request May 13, 2024
* fix(plugins): correct relative path support (#4125)

* fix(plugins): correct relative path support

* updates

(cherry picked from commit 75bf998)

* helper

* changelog

---------

Co-authored-by: Julien Robert <[email protected]>
julienrbrt added a commit that referenced this pull request May 13, 2024
* fix(plugins): correct relative path support

* updates

* helper

---------

Co-authored-by: Danilo Pantani <[email protected]>
julienrbrt added a commit that referenced this pull request May 29, 2024
* fix(plugins): correct relative path support

* updates
julienrbrt added a commit that referenced this pull request May 29, 2024
* fix(plugins): correct relative path support

* updates

* helper

---------

Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs type:internal type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants