Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cmd)!: deprecate ignite node command #4189

Merged
merged 6 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
- [#4160](https://github.com/ignite/cli/pull/4160) Enable copyloopvar linter
- [#4162](https://github.com/ignite/cli/pull/4162) Enable errcheck linter
- [#4194](https://github.com/ignite/cli/pull/4194) Bump client/v2 to `v2.0.0-beta.2`
- [#4189](https://github.com/ignite/cli/pull/4189) Deprecate `ignite node` for `ignite connect` app

### Fixes

Expand Down
2 changes: 1 addition & 1 deletion ignite/cmd/account.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func NewAccount() *cobra.Command {
Short: "Create, delete, and show Ignite accounts",
Long: `Commands for managing Ignite accounts. An Ignite account is a private/public
keypair stored in a keyring. Currently Ignite accounts are used when interacting
with Ignite relayer commands and when using "ignite network" commands.
with Ignite Apps (namely ignite relayer, ignite network and ignite connect).

Note: Ignite account commands are not for managing your chain's keys and accounts. Use
you chain's binary to manage accounts from "config.yml". For example, if your
Expand Down
10 changes: 4 additions & 6 deletions ignite/cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ To get started, create a blockchain:
NewScaffold(),
NewChain(),
NewGenerate(),
NewNode(),
NewAccount(),
NewDocs(),
NewVersion(),
Expand Down Expand Up @@ -148,11 +147,6 @@ func flagSetHome() *flag.FlagSet {
return fs
}

func getHome(cmd *cobra.Command) (home string) {
home, _ = cmd.Flags().GetString(flagHome)
return
}

func flagSetConfig() *flag.FlagSet {
fs := flag.NewFlagSet("", flag.ContinueOnError)
fs.StringP(flagConfig, "c", "", "path to Ignite config file (default: ./config.yml)")
Expand Down Expand Up @@ -239,6 +233,10 @@ func deprecated() []*cobra.Command {
Use: "faucet",
Deprecated: "use `ignite chain faucet` instead.",
},
{
Use: "node",
Deprecated: "use ignite connect app instead (ignite app install -g github.com/ignite/apps/connect).",
},
}
}

Expand Down
80 changes: 0 additions & 80 deletions ignite/cmd/node.go

This file was deleted.

76 changes: 0 additions & 76 deletions ignite/cmd/node_query.go

This file was deleted.

14 changes: 0 additions & 14 deletions ignite/cmd/node_query_bank.go

This file was deleted.

59 changes: 0 additions & 59 deletions ignite/cmd/node_query_bank_balances.go

This file was deleted.

45 changes: 0 additions & 45 deletions ignite/cmd/node_query_tx.go

This file was deleted.

Loading
Loading