Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not proxy sentry dsn (#4359) #4363

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ignite/cmd/ignite/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func run() int {
}
var wg sync.WaitGroup
analytics.SendMetric(&wg, subCmd)
analytics.EnableSentry(&wg, ctx)
analytics.EnableSentry(ctx, &wg)

err = cmd.ExecuteContext(ctx)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions ignite/cmd/testnet_inplace.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package ignitecmd

import (
sdk "github.com/cosmos/cosmos-sdk/types"

"github.com/spf13/cobra"

sdk "github.com/cosmos/cosmos-sdk/types"

"github.com/ignite/cli/v28/ignite/pkg/cliui"
"github.com/ignite/cli/v28/ignite/pkg/cosmosaccount"
"github.com/ignite/cli/v28/ignite/pkg/errors"
Expand Down
2 changes: 1 addition & 1 deletion ignite/internal/analytics/analytics.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func SendMetric(wg *sync.WaitGroup, cmd *cobra.Command) {
}

// EnableSentry enable errors reporting to Sentry.
func EnableSentry(wg *sync.WaitGroup, ctx context.Context) {
func EnableSentry(ctx context.Context, wg *sync.WaitGroup) {
dntInfo, err := checkDNT()
if err != nil || dntInfo.DoNotTrack {
return
Expand Down
2 changes: 1 addition & 1 deletion ignite/pkg/announcements/announcement.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type announcement struct {
}

func GetAnnouncements() string {
resp, err := http.Get(AnnouncementAPI)
resp, err := http.Get(AnnouncementAPI) //nolint:gosec
if err != nil || resp.StatusCode != 200 {
return fallbackData()
}
Expand Down
2 changes: 1 addition & 1 deletion ignite/pkg/sentry/sentry.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"github.com/ignite/cli/v28/ignite/version"
)

const IgniteDNS = "https://bugs.ignite.com"
const IgniteDNS = "https://[email protected]/4507891348930560"

func InitSentry(ctx context.Context) (deferMe func(), err error) {
sentrySyncTransport := sentry.NewHTTPSyncTransport()
Expand Down
Loading