fix: fix gentx parser into the cosmosutil package #4402
Merged
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator Address in MsgCreateValidator is deprecated
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
github-actions
bot
added
component:ci
julienrbrt
approved these changes
Nov 8, 2024
salmad3
approved these changes
Nov 11, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Fix gentx parser into the cosmosutil package because the use of Delegator Address in MsgCreateValidator is deprecated * add changelog (cherry picked from commit bf2539d) # Conflicts: # ignite/pkg/cosmosutil/gentx.go
|
How come this required test failed and this got merged: https://github.com/ignite/cli/actions/runs/11748957708/job/32734166739#step:4:1 |
julienrbrt
added a commit
that referenced
this pull request
Nov 12, 2024
This reverts commit bf2539d.
seems the test fail because race condition, not because the changes |
that's why, as I cannot reproduce it without it, but maybe it is flaky indeed. 🤷🏾♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gentx parser into the cosmosutil package because the use of Delegator Address in MsgCreateValidator is deprecated
https://github.com/cosmos/cosmos-sdk/blob/8bfcf554275c1efbb42666cc8510d2da139b67fa/proto/cosmos/staking/v1beta1/tx.proto#L66-L69