fixes #24: Compatibility with Openfire 5.0.0 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To quote Joakim Erdfelt, a Jetty developer: > For a `WebAppContext`, this manual initialization of JasperInitializer is not necessary. (it is necessary for a `ServletContextHandler`) > The fact that jetty-ee8-apache-jsp-<ver>.jar is in your classpath should be enough for that webapp to automatically have JSP support enabled. > > If you find that you don't have a `jsp` servlet initialized, then that means you'll want to declare the `WebAppContext.setDefaultDescriptor()` to point to the `webdefault-ee8.xml` for your version. You can find that file in the `jetty-ee8-webapp-<ver>-config.jar` - > See https://repo1.maven.org/maven2/org/eclipse/jetty/ee8/jetty-ee8-webapp/12.0.14/
Removing initialization of an attribute that I believe to be something that has been carried over from earlier versions, without this being neccesary anymore.
Updates the plugin to be compatible with Openfire 5.0.0 (in particular: with the new version of Jetty that's part of that release). This drops compatibility with versions of Openfire prior to 5.0.0.
|
This build currently fails, as it depends on changes in Openfire that are under development in igniterealtime/Openfire#2604 but have not been merged yet (making them unavailable to this PR). |
|
This is now ready to be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various commits that make this plugin compatible with Openfire 5.0.0, in particular in context of the update of the embedded webserver (Jetty) that this release contains.