-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for video/audio in iframe #932
base: master
Are you sure you want to change the base?
Conversation
…ange the playback speed via an interactive context menu.
I think the idea is good but why do you use an onInstalled listener? const speedMod = (multiplier) => {
const elements = document.querySelectorAll('video, audio');
if (elements) {
for (let i = 0; i < elements.length; ++i) {
try {
const element = elements[i];
if (element != null && media.playbackRate != null) {
media.playbackRate *= multiplier;
}
} catch (e) {
console.error(e);
}
}
}
} Not sure if the if elements is needed as i would expect there to always get a array back filled or empty. |
I'm sorry. You are right, I was aware of the things you pointed out, but I thought they were minor details, so I ended up implementing them now. |
I can't do either it's not my repository. I am only giving feedback so that you can implement it cleaner. |
I like the functionality but agree with @pepijnmm's feedback on the implementation. Do you have bandwidth to update/clean it up? |
Please check it out. |
To accommodate video/audio in iframes, I have added the ability to change the playback speed via an interactive context menu.