Skip to content

Commit

Permalink
Specially Check for 403 and Tweak Release Document
Browse files Browse the repository at this point in the history
  • Loading branch information
iguessthislldo committed Feb 14, 2024
1 parent 00456bc commit 2b4392c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/internal/release.rst
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ Upload Artifacts from Release Workflows

This should only be done for the :ref:`latest release <release-latest-release>`.

During the release script there are steps that trigger :ref:`release workflows <release-workflows>` on GitHub Actions and print out links to the runs.
The release script has steps that trigger :ref:`release workflows <release-workflows>` on GitHub Actions and print out links to the runs.
After they have finished successfully, run the release script with the version and workspace arguments and the ``--upload-artifacts`` option.
If the workflows are still in progress it will say so and give the links again.
If the workflows were successful, it will download the artifacts, package them, and upload them to GitHub.
Expand Down
2 changes: 1 addition & 1 deletion tools/scripts/gitrelease.pl
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ sub download {
}

my @redirects = $response->redirects();
if (!$response->is_success() && scalar(@redirects) && $args{redirect_retry_no_auth}) {
if ($response->code() == 403 && scalar(@redirects) && $args{redirect_retry_no_auth}) {
# Workaround redirect to real artifact URL failing because of authorization:
# https://github.com/orgs/community/discussions/88698
$request->remove_header('Authorization');
Expand Down

0 comments on commit 2b4392c

Please sign in to comment.