[IHRACP-4621] Adding an 'action' key in the offers schema. (#94)

* Adding an 'action' key in the offers schema. * Update language parameter in conf.py as per below: sphinx-doc/sphinx#10474 Co-authored-by: priyanshu mayank <[email protected]> Co-authored-by: Mohit Thakkar <[email protected]>
iheartradio · Sep 20, 2022 · 7e1ea3f · 7e1ea3f
1 parent feb0e0b
commit 7e1ea3f
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 2 deletions.
diff --git a/docs/changes.rst b/docs/changes.rst
@@ -2,6 +2,12 @@
 Changelog
 =========
 
+Version 2.7.0
+==============
+
+- Adding an ``action`` key in the offers schema, this specifies the
+  action [``upsert`` or ``takedown``] at offers level.
+
 Version 2.6.0
 ==============
 

diff --git a/docs/conf.py b/docs/conf.py
@@ -73,7 +73,7 @@
 #
 # This is also used if you do content translation via gettext catalogs.
 # Usually you set "language" from the command line for these cases.
-language = None
+language = 'en'
 
 # There are two options for replacing |today|: either, you set today to some
 # non-false value, then it is used:

diff --git a/pipeline/schema.py b/pipeline/schema.py
@@ -295,6 +295,7 @@ def validate_schema(schema, message, logger=None):
 """
 
 offer = SchemaAllRequired({
+    'action': str,
     'commercialModelType': CommercialModelType,
     'licensee': str,
     Optional('price'): Any(None, str),

diff --git a/setup.py b/setup.py
@@ -2,7 +2,7 @@
 
 setup(
     name='pipeline',
-    version='2.6.0',
+    version='2.7.0',
     packages=find_packages(exclude=['tests']),
     install_requires=[
         'Henson>=0.5.0',

diff --git a/tests/data/schema/valid-nulled-schema.json b/tests/data/schema/valid-nulled-schema.json
@@ -28,6 +28,7 @@
     "numVolumes": 1,
     "offers": [
         {
+            "action": "upsert",
             "commercialModelType": "SubscriptionModel",
             "licensee": "iheart",
             "territoryCode": "WW",
@@ -39,6 +40,7 @@
             "validThrough": "2100-01-01T00:00:00.000000+00:00"
         },
         {
+            "action": "upsert",
             "commercialModelType": "AdvertisementSupportedModel",
             "licensee": "iheart",
             "territoryCode": "WW",
@@ -99,6 +101,7 @@
             "number": 1,
             "offers": [
                 {
+                    "action": "upsert",
                     "commercialModelType": "SubscriptionModel",
                     "licensee": "iheart",
                     "territoryCode": "AU",
@@ -110,6 +113,7 @@
                     "validThrough": "2100-01-01T00:00:00.000000+00:00"
                 },
                 {
+                    "action": "upsert",
                     "commercialModelType": "AdvertisementSupportedModel",
                     "licensee": "iheart",
                     "territoryCode": "AU",

diff --git a/tests/data/schema/valid-offer.json b/tests/data/schema/valid-offer.json
@@ -1,4 +1,5 @@
 {
+    "action": "upsert",
     "commercialModelType": "SubscriptionModel",
     "licensee": "iheart",
     "territoryCode": "US",

diff --git a/tests/data/schema/valid.json b/tests/data/schema/valid.json
@@ -29,6 +29,7 @@
     "numVolumes": 1,
     "offers": [
         {
+            "action": "upsert",
             "commercialModelType": "AdvertisementSupportedModel",
             "licensee": "iHeartMedia",
             "territoryCode": "US",
@@ -101,6 +102,7 @@
             },
             "offers": [
                 {
+                    "action": "upsert",
                     "commercialModelType": "SubscriptionModel",
                     "licensee": "iHeartMedia",
                     "territoryCode": "US",