Adding all timezone offsets #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2024 11:51
daleyp24
reviewed
Sep 4, 2024
setup.py
Outdated
| long_description = f.read() | ||
| released_version = os.environ.get('VERSION') | ||
| released_version = "1.9.2dev171" |
There was a problem hiding this comment.
It kept producing "already existing" versions, so I had to hard code it. Obviously I won't be deploying with that dev version.
daleyp24
reviewed
Sep 4, 2024
IanNoyes
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Tested with multiple feeds and the start_date value end up matching what we already have in prod except for the newly added timezones and the -0000 timezone which appears to have parsed incorrectly anyways.
Will need to be ready for a spike in updated shows when this happens as it exposes the possibility to alter the md5 calculations.
daleyp24
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
https://ihm-it.atlassian.net/browse/IHRACP-7339
Description
Major Changes:
Adding timezone offsets for each timezone
Since pre-commit was not installed, this push did a lot of re-formatting. For the sake of this PR, Lines 276-337 in Item.py are the only files that were functionally updated.