-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a warning dialog upon a map file loading failure #9278
Conversation
close #9250 Since PoL map is renamed that it could be considered as corrupted as it was modified manually. We don't need to show a very detailed explanation for this matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ihhub. When testing this only part of the main menu background is redrawn upon showing the dialog:
Resolution 640x480. French assets. I removed the heroes2x.agg and left all other pol files in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new dialogue shows up for maps with renamed extensions as intended, but the menu screen is only partly drawn (looks cropped) as long as the dialogue is visible.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good now. Tested by deleting expansion data file, then renaming Arrax map extension to mp2. Error dialog comes up and there is no cropping of the menu.
close #9250
Since the PoL map is renamed that it could be considered as corrupted as it was modified manually. We don't need to show a very detailed explanation for this matter.