Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning dialog upon a map file loading failure #9278

Merged
merged 5 commits into from
Dec 14, 2024

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Nov 18, 2024

close #9250

Since the PoL map is renamed that it could be considered as corrupted as it was modified manually. We don't need to show a very detailed explanation for this matter.

close #9250

Since PoL map is renamed that it could be considered as corrupted as it was modified manually. We don't need to show a very detailed explanation for this matter.
@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff labels Nov 18, 2024
@ihhub ihhub added this to the 1.1.4 milestone Nov 18, 2024
@ihhub ihhub self-assigned this Nov 18, 2024
@ihhub ihhub changed the title Show a dialog upon map file loading failure Show a dialog upon a map file loading failure Nov 18, 2024
@ihhub ihhub changed the title Show a dialog upon a map file loading failure Show a warning dialog upon a map file loading failure Nov 18, 2024
@ihhub ihhub requested a review from Branikolog November 18, 2024 10:35
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihhub. When testing this only part of the main menu background is redrawn upon showing the dialog:
image

Resolution 640x480. French assets. I removed the heroes2x.agg and left all other pol files in place.

Copy link

@mind-james mind-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new dialogue shows up for maps with renamed extensions as intended, but the menu screen is only partly drawn (looks cropped) as long as the dialogue is visible.

@ihhub ihhub marked this pull request as draft November 22, 2024 01:59
@ihhub ihhub modified the milestones: 1.1.4, 1.1.5 Nov 27, 2024
@ihhub ihhub marked this pull request as ready for review December 5, 2024 14:31
@ihhub ihhub requested review from zenseii and mind-james December 5, 2024 14:31
Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link

@mind-james mind-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good now. Tested by deleting expansion data file, then renaming Arrax map extension to mp2. Error dialog comes up and there is no cropping of the menu.

@ihhub ihhub removed the request for review from Branikolog December 12, 2024 15:39
@ihhub ihhub merged commit 08d6434 into master Dec 14, 2024
21 checks passed
@ihhub ihhub deleted the corrupted-map-window branch December 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modified PoL maps loading with SW/demo resources
4 participants