define pytest logs directory #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Category: feature JIRA issue: MIC-5503 Add with checks. Testing Added multiple assert statements that would fail using with check and verified that they all appeared in the output logs.
hussain-jafari
requested review from
albrja,
patricktnast,
rmudambi and
stevebachmeier
as code owners
stevebachmeier
approved these changes
Feb 11, 2025
| @@ -16,13 +16,31 @@ | |||
| (["--dataset", "wic", "--year", "2015"]), | |||
| # (["--dataset", "wic", "--population", "USA", "--state", "RI", "--year", "2015"]), | |||
| ], | |||
| ids=["1", "2", "3", "4"], | |||
There was a problem hiding this comment.
We'd talked at some point about automating these IDs to that (1) they are more descriptive and (2) so that they auto-adjust when you add/remove parameterizations. Maybe: ids=lambda x: "_".join([item for item in x if not item.startswith("--")]),
| "--release", | ||
| "test_release.py", | ||
| "--check-max-tb=1000", | ||
| "--population", |
There was a problem hiding this comment.
Why are you hard-coding population instead of parametrizing it?
| assert result.returncode == 0 | ||
|
|
||
| # log using job id | ||
| job_id = request.node.callspec.id |
There was a problem hiding this comment.
I think this is even more of a reason to descriptively handle job IDs. pytest_wic_2015.o is a lot more informative than pytest_4.o.
| @@ -16,13 +16,31 @@ | |||
| (["--dataset", "wic", "--year", "2015"]), | |||
| # (["--dataset", "wic", "--population", "USA", "--state", "RI", "--year", "2015"]), | |||
There was a problem hiding this comment.
Should these all be uncommented?
patricktnast
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define pytest logs directory
Description
Add output-dir option when running pytest.
Create profiling directory using this output directory.
Update test_runner to write logs.
Testing
Ran test_runner.py and checked that the logs directory and profiling directory were created and populated as expected.