New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements #74

Open

Laxilef wants to merge 4 commits into ihormelnyk:master from Laxilef:small_improv

Contributor

Laxilef commented Dec 30, 2024

Hi @ihormelnyk,

I added something that might be useful when extending:

Ability to override OpenTherm::sendRequest(). Since it is used in other methods (OpenTherm::setBoilerStatus() and others), without virtual its logic cannot be changed
With inheritance private adds problems in development, so I suggest changing it to protected

And I think it would be correct to set the out pin state to LOW when calling OpenTherm::end().
What do you think about these changes? Thanks.

Laxilef added 4 commits

December 30, 2024 17:50


          Add virtual for OpenTherm::sendRequest()

98e31c2


          Member access from private to protected

a9b19b0


          Set out pin LOW when ending

7579c67


          Reset statuses in OpenTherm::end()

47663ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet