Annotate cat_list()
#896
Merged
Annotate cat_list()
#896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
=====================================
Coverage 95.6% 95.6%
=====================================
Files 46 46
Lines 4338 4338
=====================================
Hits 4148 4148
Misses 190 190
|
|
Should we now merge this? |
|
Good to merge anytime :) |
glatterf42
force-pushed
the
type-hint-cat-list
branch
from
8d3b772 to
ab60564
Compare
khaeru
approved these changes
Jan 7, 2025
|
The stalled check "Code scanning results / CodeQL" seems to be spurious, due to some change in GitHub's behaviour. I'll ignore it and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from me wanting to showcase a small, completely typed function in the UBA presentation on Tuesday as an example for how to use docstrings. I didn't want to spend too much time looking,
cat_list()seems fine, but is missing some annotations. This PR provides them.How to review
No need to merge this (quickly), I'm mainly interested in the docs built from this PR. But of course, this is a small improvement we can bring in anytime :)
PR checklist
[ ] Add or expand tests;coverage checks both ✅ Just adding annotations.[ ] Update release notes.Just adding annotations.