Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Thumbnail from IIIF #209
base: main
Are you sure you want to change the base?
Create Thumbnail from IIIF #209
Changes from 9 commits
3c69775
73a9573
aeb6e92
8db7358
9c16236
e4eab7d
764aabd
aed113a
daf26ae
378bc0a
236ac54
a1f442e
094ab20
960eb2a
b86b2d2
167a185
280570f
2cc2f97
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get a bigger image as this can be shrinked with css and not loose quality. If we go smaller css will enlarge it and it may get pixilated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this instead generate a image closer to the size provided? Assuming its not a level0 image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glenrobson, I still need to refactor for this. Is it safe to say that what's being suggested is if no sizes property exists and the image server is not level 0, this should return a thumbnail request for the exact width. Is this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if level0 then return max or full
else
use exact side requested (for v2 width/ and for v3 width/(height)) height optional for v3 level 1 and above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still need this else statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentially move this up to the else sizes on line 55/56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if you ask for slightly smaller than a size it picks the closest bigger one.