Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for home + end keys #311

Merged

Conversation

BanuAdrian
Copy link
Contributor

@BanuAdrian BanuAdrian commented Nov 10, 2024

Made two unit tests for checking the functionality of pressing home and end keys inside the editor. Also, checked if they worked with other features such as moving the cursor up or down. (Issue #124)

@ilai-deutel
Copy link
Owner

Thank you for helping improve kibi's code coverage! Please have a look at the failed check, you need to run cargo +nightly fmt

@ilai-deutel
Copy link
Owner

@all-contributors please add @BanuAdrian for test

Copy link
Contributor

@ilai-deutel

I've put up a pull request to add @BanuAdrian! 🎉

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.47%. Comparing base (7bedad6) to head (8cf73c1).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   48.41%   51.47%   +3.05%     
==========================================
  Files          10       10              
  Lines        1138     1187      +49     
==========================================
+ Hits          551      611      +60     
+ Misses        587      576      -11     
Flag Coverage Δ
wasm32-wasip1 52.12% <100.00%> (+3.12%) ⬆️
x86_64-apple-darwin 52.21% <100.00%> (+3.11%) ⬆️
x86_64-pc-windows-gnu 51.58% <100.00%> (+3.28%) ⬆️
x86_64-unknown-linux-gnu 52.12% <100.00%> (+3.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilai-deutel ilai-deutel merged commit 1628b51 into ilai-deutel:master Nov 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants