Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More mass density and specific volume units #489

Conversation

cutlerjake
Copy link
Contributor

@cutlerjake cutlerjake commented Oct 24, 2024

Description

This PR introduces two new mass density units: ton_long_per_cubic_foot and ton_short_per_cubic_foot. Additionally, it includes the inverse units for all mass density units in SpecificVolume.

Key Changes

  • New Units: ton_long_per_cubic_foot and ton_short_per_cubic_foot
  • SpecificVolume: Inverse of all MassDensity units have been added to SpecificVolume
  • Test Coverage: Tests have been added for all new units
  • Test Changes: SpecificVolume tests now use Test::assert_approx_eq

It would be great to get these units added, and I’m happy to address any feedback or comments.

@iliekturtles iliekturtles force-pushed the more-mass-density-and-specific-volume-units branch from aa5502d to f28c0e3 Compare February 16, 2025 19:29
@iliekturtles iliekturtles merged commit bf5a534 into iliekturtles:master Feb 16, 2025
4 of 14 checks passed
@iliekturtles
Copy link
Owner

Thank you for the PR and sorry for the delay. I amended your commits with a few formatting changes and have merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants