-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024 Update #20
Merged
Merged
2024 Update #20
Changes from 36 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
799ee7e
updates dependencies.
stopfstedt 335aa1d
tranform phpunit config file to v11 compliant format.
stopfstedt 04b6ccf
adjust name of phpunit cache file in git ignore list.
stopfstedt e5a48af
update minimum PHP version requirement to 8.1
stopfstedt 845d813
bump PHP version to 8.1 on GH actions.
stopfstedt 88cf6db
adds phpcs config file and configures its cache file to be git-ignored.
stopfstedt 05e8110
ditch command line flags from phpcs invocations in the CI.
stopfstedt d611111
updates test coverage.
stopfstedt 87eb375
updates model classes.
stopfstedt b1d7776
make $name attr "nullable".
stopfstedt e9d89d5
dissolve Nameable trait.
stopfstedt 6da2d64
expand scope of setter/getter test helper to allow for NULL input che…
stopfstedt eebef5a
unearth PHPUnit attribute from docblock.
stopfstedt 871576c
appease the code linter.
stopfstedt 8c1d34c
updates links and docs.
stopfstedt 583c3f4
expand test matrix to PHP 8.2 and 8.3
stopfstedt d15f0ab
ditch PHP 8.1. update dependencies.
stopfstedt c590765
https it is.
stopfstedt 573650f
add PHPStan to the mix.
stopfstedt 8aeddfc
declare the XMLWriter PHP extension as requirement.
stopfstedt 9407b30
declare the DOM PHP extension as requirement.
stopfstedt 4d019ca
cleanup the Parser class.
stopfstedt 7449a01
rm unused class constants.
stopfstedt 510c548
consolidate case statements with same body.
stopfstedt c08bd30
rm dead code branch.
stopfstedt d7c4b57
update file name in code example.
stopfstedt 0a32f40
dial in PHPCS config and streamline linting step in the CI.
stopfstedt 8774940
run PHPStan in the CI pipeline.
stopfstedt 638ae89
update actions/checkout to v4
stopfstedt 66418e5
initalize nullable class member to null.
stopfstedt d07af88
updates model tests to invoke getter/setters tests for nullable attri…
stopfstedt f4f66aa
configure PHPUnit for code coverage.
stopfstedt 97885ce
update setter/getter test helper for object attrs that can be nulled.
stopfstedt d2f01a5
adds dependabot configuration.
stopfstedt 6ce9da8
git ignore phpunit.xml file.
stopfstedt 351eec9
put all remaining model attrs under test coverage.
stopfstedt b33920c
change dependabot interval from daily to weekly.
stopfstedt dbd97cd
adds dependency update workflow.
stopfstedt 05b99a6
rm pointless docblocks.
stopfstedt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
version: 2 | ||
updates: | ||
- package-ecosystem: composer | ||
directory: "/" | ||
schedule: | ||
interval: daily | ||
time: "02:30" | ||
timezone: America/Los_Angeles | ||
open-pull-requests-limit: 10 | ||
- package-ecosystem: github-actions | ||
directory: "/" | ||
schedule: | ||
interval: daily | ||
time: "02:30" | ||
timezone: America/Los_Angeles | ||
open-pull-requests-limit: 10 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
*~ | ||
*.patch | ||
/bin/* | ||
/html-coverage/ | ||
/vendor/ | ||
.phpunit.result.cache | ||
.phpunit.cache | ||
.phpcs-cache | ||
phpunit.xml | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
"Ilios", | ||
"MeSH" | ||
], | ||
"homepage": "http://iliosproject.org/", | ||
"homepage": "https://iliosproject.org/", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So secure! |
||
"license": "MIT", | ||
"authors": [ | ||
{ | ||
|
@@ -16,13 +16,16 @@ | |
} | ||
], | ||
"require": { | ||
"php": ">=8.0" | ||
"php": ">=8.2", | ||
"ext-dom": "*", | ||
"ext-xmlreader": "*" | ||
}, | ||
"require-dev": { | ||
"mockery/mockery": "@stable", | ||
"phpunit/phpunit": "@stable", | ||
"squizlabs/php_codesniffer": "@stable", | ||
"fakerphp/faker": "@stable" | ||
"fakerphp/faker": "@stable", | ||
"phpstan/phpstan": "^1.10" | ||
}, | ||
"autoload": { | ||
"psr-4": { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given our infrequent release here I think weekly may be a better choice with less PRs to manage. I wonder if it's worth pulling in the update-dependencies and maybe adding auto merge as well to keep the number even lower?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to weekly and deps update workflow added ✔️