-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slob: make audio work in AARD2 for android and aard2-web (breaks audio in goldendict desktop) #534
Conversation
…io in goldendict desktop) - fix audio for AARD2: - https://play.google.com/store/apps/details?id=itkach.aard2 - https://github.com/itkach/aard2-android - fix audio for AARD2-WEB: - https://github.com/itkach/aard2-web # NOTE - !! breaks audio in goldendict desktop: [goldendict](http://goldendict.org) & [goldendict-ng](https://github.com/xiaoyifang/goldendict-ng)
Please add an option for GoldenDict, similar to this: |
Run this after adding the option: |
Have you tested with Aard2-web? Also run |
yep, audio works with both aard2-web and android aard2 app
would be these that need fixing, right? should I fix only those in this pr or all?
update: fixed, now only these two are left acorrding to
should they be left as is? |
…conditional on flag - fix formatting
I'm not sure the change in DSL plugin is a good idea. |
If your problem is only with Aard2, you probably should only change Aard2 plugin and nothing else. |
reverted |
slob: make audio work in AARD2 for android and aard2-web (!breaks audio in goldendict desktop)
NOTE
sound://audio.mp3
and absolute links that start with/
which are not valid for AARD2