Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiphysics (production) #630

Closed
wants to merge 47 commits into from
Closed

Multiphysics (production) #630

wants to merge 47 commits into from

Conversation

majosm
Copy link
Collaborator

@majosm majosm commented Apr 4, 2022

Working-ish draft of grudge-based multiphysics. Need to separate some of this out into simpler PRs.

Depends on inducer/grudge#246, inducer/meshmode#309.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@majosm majosm force-pushed the multiphysics-production branch 3 times, most recently from 0de9ae1 to 3166572 Compare April 12, 2022 15:03
@majosm majosm force-pushed the multiphysics-production branch from 3166572 to 13caba5 Compare April 12, 2022 15:04
@majosm majosm force-pushed the multiphysics-production branch from 681080d to cf1b0ab Compare April 13, 2022 14:07
majosm and others added 11 commits April 13, 2022 13:07
@majosm majosm force-pushed the multiphysics-production branch from 13fe8ae to c4128f7 Compare May 4, 2022 17:09
@majosm majosm force-pushed the multiphysics-production branch from 5d45df5 to 09feb28 Compare May 20, 2022 19:57
majosm added 18 commits July 5, 2022 16:00
@majosm
Merge remote-tracking branch 'origin/production' into multiphysics-pr…
bbbcf04 
…oduction
@majosm
fix requirements.txt
79cf3a6
@majosm
use PartID type from grudge
85744b8
@majosm
Merge remote-tracking branch 'origin/production' into multiphysics-pr…
435009c 
…oduction
@majosm
Merge remote-tracking branch 'origin/production' into multiphysics-pr…
3238344 
…oduction
@majosm
change grudge branch in requirements.txt
2861b7e
@majosm
Merge remote-tracking branch 'origin/production' into multiphysics-pr…
6de252d 
…oduction
@majosm
change DTAG_BOUNDARY -> BoundaryDomainTag in combozzle
574839a
@majosm
Merge remote-tracking branch 'origin/production' into multiphysics-pr…
1bdf3ea 
…oduction
@majosm
update create_discretization_collection
73064de
@majosm
use IsothermalWallBoundary instead of IsothermalNoSlipBoundary in mul…
8123516 
…ti-volume example
@majosm
support multiple volumes in componentwise_norm and max_component_norm
2fa258d
@majosm
fix overintegration bug
4347f1e
@majosm
add multiphysics tests
99a921e
@majosm
Merge remote-tracking branch 'origin/production' into multiphysics-pr…
3ad041a 
…oduction
@majosm
fix some things in multiphysics tests
b3e66f9
@majosm
Merge remote-tracking branch 'origin/production' into multiphysics-pr…
c050410 
…oduction
@majosm
fix flake8 errors
d00de99
@majosm majosm force-pushed the multiphysics-production branch from f45abf8 to d00de99 Compare August 10, 2022 18:08
@majosm majosm mentioned this pull request Aug 15, 2022
Merged
11 tasks
@majosm
Copy link
Collaborator Author

majosm commented Sep 21, 2022

Superseded by #726 and #767.

@majosm majosm closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majosm @MTCam