Skip to content
This repository has been archived by the owner on Jan 11, 2022. It is now read-only.

UI/UX Change + Added ability to type in coordinates & Filter by creators #33

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

UI/UX Change + Added ability to type in coordinates & Filter by creators #33

wants to merge 7 commits into from

Conversation

duanegroves
Copy link

Small tweak to where if the image exists it will display the image in the tile

@duanegroves duanegroves changed the title Added display of images if they exist Added display of images if they exist & ability to type in coordinates Dec 10, 2021
@duanegroves duanegroves changed the title Added display of images if they exist & ability to type in coordinates Added display of Images if they exist in response & ability to type in coordinates Dec 10, 2021
wadefagen
wadefagen suggested changes Dec 10, 2021
View reviewed changes
Copy link
Member

@wadefagen wadefagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The way of implementing an image is very hacky, relying on a try-catch for expected behavior (no image). See the in-line comments on fixes. Additionally, please remove all debug code before a PR.

templates/index.html Outdated Show resolved Hide resolved
templates/index.html Outdated Show resolved Hide resolved
templates/index.html Outdated Show resolved Hide resolved
templates/index.html Outdated Show resolved Hide resolved
static/tile.js Outdated Show resolved Hide resolved
@duanegroves duanegroves changed the title Added display of Images if they exist in response & ability to type in coordinates Added ability to type in coordinates Dec 10, 2021
@duanegroves
Copy link
Author

image
Please accept ;(

@duanegroves
Copy link
Author

I took out the image Feature you can see from the above comment on why. But I updated the frontend visualization and added the ability to add coordinates yourself. Please accept ;(

@duanegroves
Copy link
Author

image

@duanegroves
Copy link
Author

Two things I wanted to add but didn't get around to:

  1. Adding the possibility for images with responses
  2. Being able to filter by people
  • I don't know how to do that in javascript exactly. Though I know how to do it in Angular

@duanegroves duanegroves changed the title Added ability to type in coordinates UI/UX Change + Added ability to type in coordinates & Filter by creators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wadefagen wadefagen Awaiting requested review from wadefagen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duanegroves @wadefagen