Skip to content

Commit

Permalink
Synthesize assembly names by default for ilproj-based tests (dotnet#1…
Browse files Browse the repository at this point in the history
…08997)

* Synthesize ilasm assembly names by default for all IL tests
* Fix diamondshape tests
  • Loading branch information
kg authored Oct 23, 2024
1 parent e70aaa8 commit edaa25e
Show file tree
Hide file tree
Showing 3 changed files with 56 additions and 48 deletions.
9 changes: 9 additions & 0 deletions src/tests/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@
<RestorePackages>false</RestorePackages>
</PropertyGroup>

<!-- Most IL tests do not depend on having a specific assembly name, but some of them contain
hard-coded assembly name directives which are incorrect. This MSBuild property default configures ilasm
to override the assembly name directive when assembling so that it matches the output dll name,
which fixes a variety of failures in crossgen r2r tests (from not being able to find dlls for references).
-->
<PropertyGroup>
<SynthesizeIlasmAssemblyName>true</SynthesizeIlasmAssemblyName>
</PropertyGroup>

<!-- Which tests shall we build? Default: Priority 0 tests.
At the command-line, the user can specify /p:CLRTestPriorityToBuild=666 (for example), and
all tests with CLRTestPriority 666,..., 1 AND 0 will build.
Expand Down
Loading

0 comments on commit edaa25e

Please sign in to comment.