Skip to content

Commit

Permalink
Revert "Replace internal SWTEventListener directly with
Browse files Browse the repository at this point in the history
java.util.EventListener"

This reverts commit bd306ac.

Replacing SWTEventListener directly with java.util.EventListener breaks
binary compatibility with bundles compiled against any older SWT
version.

See discussion on
eclipse-platform#1101
  • Loading branch information
iloveeclipse committed Mar 13, 2024
1 parent bd306ac commit 83bc42d
Show file tree
Hide file tree
Showing 64 changed files with 173 additions and 135 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.accessibility;

import java.util.*;
import org.eclipse.swt.internal.SWTEventListener;

/**
* Classes which implement this interface provide methods
Expand All @@ -30,7 +30,7 @@
*
* @since 3.6
*/
public interface AccessibleActionListener extends EventListener {
public interface AccessibleActionListener extends SWTEventListener {
/**
* Returns the number of accessible actions available in this object.
* <p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.accessibility;

import java.util.*;
import org.eclipse.swt.internal.SWTEventListener;

/**
* Classes which implement this interface provide methods
Expand All @@ -31,7 +31,7 @@
*
* @since 3.6
*/
public interface AccessibleAttributeListener extends EventListener {
public interface AccessibleAttributeListener extends SWTEventListener {
/**
* Returns attributes specific to this Accessible object.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
package org.eclipse.swt.accessibility;


import java.util.*;
import org.eclipse.swt.internal.*;

/**
* Classes that implement this interface provide methods
Expand Down Expand Up @@ -43,7 +43,7 @@
*
* @since 2.0
*/
public interface AccessibleControlListener extends EventListener {
public interface AccessibleControlListener extends SWTEventListener {

/**
* Sent when an accessibility client requests the identifier
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.accessibility;

import java.util.*;
import org.eclipse.swt.internal.SWTEventListener;

/**
* Classes which implement this interface provide methods
Expand All @@ -31,7 +31,7 @@
*
* @since 3.7
*/
public interface AccessibleEditableTextListener extends EventListener {
public interface AccessibleEditableTextListener extends SWTEventListener {
/**
* Copies the substring beginning at the specified <code>start</code> offset
* and extending to the character at offset <code>end - 1</code> to the clipboard.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.accessibility;

import java.util.*;
import org.eclipse.swt.internal.SWTEventListener;

/**
* Classes which implement this interface provide methods
Expand All @@ -30,7 +30,7 @@
*
* @since 3.6
*/
public interface AccessibleHyperlinkListener extends EventListener {
public interface AccessibleHyperlinkListener extends SWTEventListener {
/**
* Returns the anchor for the link at the specified index.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
package org.eclipse.swt.accessibility;


import java.util.*;
import java.util.function.*;

import org.eclipse.swt.internal.*;

/**
* Classes that implement this interface provide methods
* that deal with the events that are generated when an
Expand All @@ -40,7 +41,7 @@
*
* @since 2.0
*/
public interface AccessibleListener extends EventListener {
public interface AccessibleListener extends SWTEventListener {

/**
* Sent when an accessibility client requests the name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.accessibility;

import java.util.*;
import org.eclipse.swt.internal.SWTEventListener;

/**
* Classes which implement this interface provide methods
Expand All @@ -30,7 +30,7 @@
*
* @since 3.6
*/
public interface AccessibleTableCellListener extends EventListener {
public interface AccessibleTableCellListener extends SWTEventListener {
/**
* Returns the number of columns occupied by this cell accessible.
* <p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.accessibility;

import java.util.*;
import org.eclipse.swt.internal.*;

/**
* Classes which implement this interface provide methods
Expand All @@ -35,7 +35,7 @@
*
* @since 3.6
*/
public interface AccessibleTableListener extends EventListener {
public interface AccessibleTableListener extends SWTEventListener {
/**
* Deselects one column, leaving other selected columns selected (if any).
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
package org.eclipse.swt.accessibility;


import java.util.*;
import org.eclipse.swt.internal.*;

/**
* Classes that implement this interface provide methods
Expand Down Expand Up @@ -43,7 +43,7 @@
*
* @since 3.0
*/
public interface AccessibleTextListener extends EventListener {
public interface AccessibleTextListener extends SWTEventListener {

/**
* Sent when an accessibility client requests the current character offset
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.accessibility;

import java.util.*;
import org.eclipse.swt.internal.SWTEventListener;

/**
* Classes which implement this interface provide methods
Expand All @@ -30,7 +30,7 @@
*
* @since 3.6
*/
public interface AccessibleValueListener extends EventListener {
public interface AccessibleValueListener extends SWTEventListener {
/**
* Returns the value of this object as a number.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.browser;

import java.util.*;
import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
Expand All @@ -26,7 +26,7 @@
* @since 3.5
*/
@FunctionalInterface
public interface AuthenticationListener extends EventListener {
public interface AuthenticationListener extends SWTEventListener {

/**
* This method is called when a page is navigated to that requires
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.browser;

import java.util.*;
import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
Expand All @@ -29,7 +29,7 @@
* @since 3.0
*/
@FunctionalInterface
public interface CloseWindowListener extends EventListener {
public interface CloseWindowListener extends SWTEventListener {

/**
* This method is called when the window hosting a {@link Browser} should be closed.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@
*******************************************************************************/
package org.eclipse.swt.browser;

import java.util.*;
import java.util.function.*;

import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
* a {@link LocationEvent} notification when a {@link Browser}
Expand All @@ -27,7 +28,7 @@
*
* @since 3.0
*/
public interface LocationListener extends EventListener {
public interface LocationListener extends SWTEventListener {

/**
* This method is called when the current location is about to be changed.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.browser;

import java.util.*;
import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
Expand All @@ -28,7 +28,7 @@
* @since 3.0
*/
@FunctionalInterface
public interface OpenWindowListener extends EventListener {
public interface OpenWindowListener extends SWTEventListener {

/**
* This method is called when a new window needs to be created.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@
*******************************************************************************/
package org.eclipse.swt.browser;

import java.util.*;
import java.util.function.*;

import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
* a {@link ProgressEvent} notification when a {@link Browser}
Expand All @@ -28,7 +29,7 @@
*
* @since 3.0
*/
public interface ProgressListener extends EventListener {
public interface ProgressListener extends SWTEventListener {

/**
* This method is called when a progress is made during the loading of the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.browser;

import java.util.*;
import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
Expand All @@ -26,7 +26,7 @@
* @since 3.0
*/
@FunctionalInterface
public interface StatusTextListener extends EventListener {
public interface StatusTextListener extends SWTEventListener {

/**
* This method is called when the status text is changed. The
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.swt.browser;

import java.util.*;
import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
Expand All @@ -26,7 +26,7 @@
* @since 3.0
*/
@FunctionalInterface
public interface TitleListener extends EventListener {
public interface TitleListener extends SWTEventListener {

/**
* This method is called when the title of the current document
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@
*******************************************************************************/
package org.eclipse.swt.browser;

import java.util.*;
import java.util.function.*;

import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
* a {@link WindowEvent} notification when a window hosting a
Expand All @@ -28,7 +29,7 @@
*
* @since 3.0
*/
public interface VisibilityWindowListener extends EventListener {
public interface VisibilityWindowListener extends SWTEventListener {

/**
* This method is called when the window hosting a <code>Browser</code>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@
*******************************************************************************/
package org.eclipse.swt.custom;

import java.util.*;
import org.eclipse.swt.internal.*;

/**
* This listener interface may be implemented in order to receive
* BidiSegmentEvents.
* @see BidiSegmentEvent
*/
@FunctionalInterface
public interface BidiSegmentListener extends EventListener {
public interface BidiSegmentListener extends SWTEventListener {

/**
* This method is called when a line needs to be reordered for
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@
*******************************************************************************/
package org.eclipse.swt.custom;

import java.util.*;
import java.util.function.*;

import org.eclipse.swt.internal.*;

/**
* Classes which implement this interface provide methods
* that deal with the events that are generated by the CTabFolder
Expand All @@ -34,7 +35,7 @@
*
* @since 3.0
*/
public interface CTabFolder2Listener extends EventListener {
public interface CTabFolder2Listener extends SWTEventListener {

/**
* Sent when the user clicks on the close button of an item in the CTabFolder.
Expand Down Expand Up @@ -116,7 +117,7 @@ public interface CTabFolder2Listener extends EventListener {

/**
* Sent when the tab items count changes
*
*
* @param event from observed tab folder
* @since 3.124
*/
Expand Down
Loading

0 comments on commit 83bc42d

Please sign in to comment.