New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl Hash for FilterType #2343

Merged

kornelski merged 1 commit into image-rs:main from Keats:main

Oct 11, 2024

Contributor

Keats commented Oct 11, 2024

I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.

--

I'm not sure if there is a reason it's not implemented but we could use that for Zola.


          Impl Hash for FilterType

3e89c79

kornelski approved these changes

View reviewed changes

Contributor

kornelski left a comment

I think it's fine to add it. Even if we added a variant that can't be hashed (like a Box<dyn fn>), we can always return some constant value for it.

kornelski merged commit 02a4928 into image-rs:main

32 checks passed

aaron404 mentioned this pull request

impl Eq for FilterType #2397

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet