Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calibration to Marching cubes mesh #623

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

rimadoma
Copy link
Contributor

@rimadoma rimadoma commented Apr 25, 2020

Adds an optional parameter to add calibration to the output mesh of DefaultMarchingCubes, as discussed on the forum

Couple of questions remaining:

  1. Should the op consider different units for different axes? How would that work? Convert all to unit of x-axis and scale with that?
  2. Is it possible to have a @Parameter CalibratedAxis[] axes? I'm getting "last argument should be vararg" errors from namespace tests.
  3. Would it make sense to have a CalibratedMarchingCubes op that takes in an ImgPlus<T>?

@kephale
Copy link
Contributor

kephale commented Apr 25, 2020

This should be accounted for in imagej-mesh: imagej/imagej-mesh#22

@frauzufall
Copy link
Member

frauzufall commented Apr 26, 2020

@rimadoma just a note, @tpietzsch and I have been working on significantly speeding up DefaultMarchingCubes on this branch. The branch is just a playground, I want to add add the new versions to imagej-mesh as static methods and call this from ops. I will ping you once there is a PR so that we can also address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants